Ant 1.9.10 and Ivy

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Ant 1.9.10 and Ivy

Gintautas Grigelionis
After Ant dependency in Ivy was updated to 1.9.10, I'm getting

    [javac]
/Users/gintas/Projects/ant-ivy-asf/src/java/org/apache/ivy/ant/IvyCacheFileset.java:206:
error: clone() in EmptyFileSet cannot override clone() in FileSet
    [javac]         public Object clone() {
    [javac]                       ^
    [javac]   return type Object is not compatible with FileSet

Any comments?

Gintas
Reply | Threaded
Open this post in threaded view
|

Re: Ant 1.9.10 and Ivy

Gintautas Grigelionis
More specifically, that's Ant 1.10.2 thing... so, one more regression in
master, I suppose. 1.10.1 and 1.9.10 work fine.

Gintas

2018-02-27 20:23 GMT+01:00 Gintautas Grigelionis <[hidden email]>:

> After Ant dependency in Ivy was updated to 1.9.10, I'm getting
>
>     [javac] /Users/gintas/Projects/ant-ivy-asf/src/java/org/apache/
> ivy/ant/IvyCacheFileset.java:206: error: clone() in EmptyFileSet cannot
> override clone() in FileSet
>     [javac]         public Object clone() {
>     [javac]                       ^
>     [javac]   return type Object is not compatible with FileSet
>
> Any comments?
>
> Gintas
>
Reply | Threaded
Open this post in threaded view
|

Re: Ant 1.9.10 and Ivy

Stefan Bodewig
On 2018-02-27, Gintautas Grigelionis wrote:

> More specifically, that's Ant 1.10.2 thing... so, one more regression in
> master, I suppose. 1.10.1 and 1.9.10 work fine.

> Gintas

> 2018-02-27 20:23 GMT+01:00 Gintautas Grigelionis <[hidden email]>:

>> After Ant dependency in Ivy was updated to 1.9.10, I'm getting

>>     [javac] /Users/gintas/Projects/ant-ivy-asf/src/java/org/apache/
>> ivy/ant/IvyCacheFileset.java:206: error: clone() in EmptyFileSet cannot
>> override clone() in FileSet
>>     [javac]         public Object clone() {
>>     [javac]                       ^
>>     [javac]   return type Object is not compatible with FileSet

This is part of the big patch that changed a lot of things. It also
changed all clone() implementations to use co-variant return types and
thus broke all subclasses that override the traditional clone signature.

I'll grep through the sources and revert all changes to clone
signatures unless anybody else beats me to it.

Many thanks for pointing out the problem.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ant 1.9.10 and Ivy

Jaikiran Pai

> I'll grep through the sources and revert all changes to clone
> signatures unless anybody else beats me to it.
>
Done
https://github.com/apache/ant/commit/2e788849136bfd75e88ce0d959810f1191d43a33

-Jaikiran

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ant 1.9.10 and Ivy

Stefan Bodewig
On 2018-02-28, Jaikiran Pai wrote:

>> I'll grep through the sources and revert all changes to clone
>> signatures unless anybody else beats me to it.

> Done
> https://github.com/apache/ant/commit/2e788849136bfd75e88ce0d959810f1191d43a33

Thanks

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]