Augmenting the ant wrapper script for OS packaging

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Augmenting the ant wrapper script for OS packaging

Stefan Bodewig
Hi all

I'm currently looking into providing Snap archives for Ant and there
seems to be an edge case where one would want to do something
Snap-specific. The case here is providing an explicit fallback for Java
if JAVA_HOME is not set and we don't find java on the PATH.

There is some precedent for packaging specific content inside of that
file (look for rpm_mode).

I'm not committing anything right now and might play with a few ideas in
a branch of a personal github fork later.

Right now I'd like to know whether there is any strong opinion around
here. Would something like this be somthing that goes into the main
distribution or something that would get patched into the script when
building the Snap archive.

I'm a bit torn but would prefer adding it to the default script so that
running Ant would use the same wrapper no matter how you've installed
it. I'm afraid we'd have to ask people "how have you installed Ant"
otherwise.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Augmenting the ant wrapper script for OS packaging

Jaikiran Pai-2

On 11/06/19 9:54 PM, Stefan Bodewig wrote:
> I'm a bit torn but would prefer adding it to the default script so that
> running Ant would use the same wrapper no matter how you've installed
> it. I'm afraid we'd have to ask people "how have you installed Ant"
> otherwise.

+1.

Given that the startup script already does a bunch of things to locate a
Java installation and the fact that what you are proposing seems to be
pretty reasonable in terms of finding the "Snap JVM", I think it's good
to have it in the default script.

-Jaikiran


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Augmenting the ant wrapper script for OS packaging

Martijn Kruithof-3
+1

On 12-06-19 07:16, Jaikiran Pai wrote:

> On 11/06/19 9:54 PM, Stefan Bodewig wrote:
>> I'm a bit torn but would prefer adding it to the default script so that
>> running Ant would use the same wrapper no matter how you've installed
>> it. I'm afraid we'd have to ask people "how have you installed Ant"
>> otherwise.
> +1.
>
> Given that the startup script already does a bunch of things to locate a
> Java installation and the fact that what you are proposing seems to be
> pretty reasonable in terms of finding the "Snap JVM", I think it's good
> to have it in the default script.
>
> -Jaikiran
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]