Bug 34680 - may I fix it?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug 34680 - may I fix it?

Stefan Bodewig
or would anybody prefer to keep the setter at package private access?
All other setters in this class are public as well.

Stefan

Trivial patch is

Index: src/main/org/apache/tools/ant/helper/AntXMLContext.java
===================================================================
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/helper/AntXMLContext.java,v
retrieving revision 1.11
diff -u -r1.11 AntXMLContext.java
--- src/main/org/apache/tools/ant/helper/AntXMLContext.java 25 Apr 2005 10:15:11 -0000 1.11
+++ src/main/org/apache/tools/ant/helper/AntXMLContext.java 2 May 2005 15:09:24 -0000
@@ -357,7 +357,7 @@
      * Set the map of the targets in the current source file.
      * @param currentTargets a map of targets.
      */
-    void setCurrentTargets(Map currentTargets) {
+    public void setCurrentTargets(Map currentTargets) {
         this.currentTargets = currentTargets;
     }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 34680 - may I fix it?

Matt Benson
+1

-Matt

--- Stefan Bodewig <[hidden email]> wrote:
> or would anybody prefer to keep the setter at
> package private access?
> All other setters in this class are public as well.
>
> Stefan


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...