[GitHub] [ant] TonyGravagno opened a new pull request #116: Fix space issue in AntStructure.DTDPrinter

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] TonyGravagno opened a new pull request #116: Fix space issue in AntStructure.DTDPrinter

GitBox
TonyGravagno opened a new pull request #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116
 
 
   Task AntStructure renders a project DTD. In AntStructure class DTDPrinter, line 327, a single statement is used to concatenate a list of enumerated values which are valid for an attribute. The list is enclosed in parentheses. At line 348 the string "#IMPLIED" is appended to all attribute definitions regardless of type. For other types like Boolean and CDATA, a space is appended. Not for these enumerations. This results in a DTD validation error. Ref [XERCES definition](https://xerces.apache.org/xerces-j/apiDocs/org/apache/xerces/utils/XMLMessages.html#MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF)
   
   The full message displayed in VSCode may be different from elsewhere:
   
       White space is required before the attribute default in the declaration
       of attribute "x" for element "y".
       xml(MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF)
   
   This simple one-line change appends the space character required to avoid that error.
   
   **Note:** This should not be modified into a change on the `joinAlts` Collector which surrounds values in parentheses. That Collector is used elsewhere where regex syntax is applied immediately after. See line 298. That asterisk cannot be separated from the values with a space. The space must only be applied to line 327.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] jaikiran commented on issue #116: Fix space issue in AntStructure.DTDPrinter

GitBox
jaikiran commented on issue #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116#issuecomment-574974375
 
 
   Hello @TonyGravagno, thank you for this PR. There was a similar changed needed a few lines below that code, which I've included in your commit and merged upstream. I've added you to our contributors list. Thanks again for this fix.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] jaikiran edited a comment on issue #116: Fix space issue in AntStructure.DTDPrinter

GitBox
In reply to this post by GitBox
jaikiran edited a comment on issue #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116#issuecomment-574974375
 
 
   Hello @TonyGravagno, thank you for this PR. There was a similar changed needed a few lines below that code, which I've included in your commit and merged upstream (https://github.com/apache/ant/commit/9b0842fafa3bf3afe11438b6349ed55173cf4327). I've added you to our contributors list. Thanks again for this fix.
   
   P.S: I forgot to auto-close this PR through the commit. Can you please close this one yourself?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] bodewig closed pull request #116: Fix space issue in AntStructure.DTDPrinter

GitBox
In reply to this post by GitBox
bodewig closed pull request #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] bodewig commented on issue #116: Fix space issue in AntStructure.DTDPrinter

GitBox
In reply to this post by GitBox
bodewig commented on issue #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116#issuecomment-575605287
 
 
   I*ve been able to close it, thanks @TonyGravagno .
   
   @jaikiran you may need to use https://gitbox.apache.org/setup/ in order to be able to close issues yourself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] TonyGravagno commented on issue #116: Fix space issue in AntStructure.DTDPrinter

GitBox
In reply to this post by GitBox
TonyGravagno commented on issue #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116#issuecomment-575848052
 
 
   Cool! Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] jaikiran commented on issue #116: Fix space issue in AntStructure.DTDPrinter

GitBox
In reply to this post by GitBox
jaikiran commented on issue #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116#issuecomment-576075533
 
 
   > @jaikiran you may need to use https://gitbox.apache.org/setup/ in order to be able to close issues yourself.
   
   Thank you Stefan. I wasn't aware of that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]