[GitHub] [ant] bodewig commented on a change in pull request #90: solve the unconsistent comments

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [ant] bodewig commented on a change in pull request #90: solve the unconsistent comments

GitBox
bodewig commented on a change in pull request #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90#discussion_r273121101
 
 

 ##########
 File path: src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
 ##########
 @@ -686,9 +686,7 @@ public void addParam(Parameter parameter) {
 
 
     /**
-     * Defined in org.apache.tools.ant.types.Parameterizable.
-     * Overwrite implementation in superclass because only special
-     * parameters are valid.
+     * Set all the Parameters for this custom selector, collected by\n the ExtendSelector class.
 
 Review comment:
   there seems to be something wrong with the new comment (literal `\n`) and I don't understand what ExtendSelector refers to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]