Quantcast

[GitHub] ant-ivy pull request #10: Fix for IVY-1531

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #10: Fix for IVY-1531

janmaterne
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/10

    Fix for IVY-1531

    The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1531.
   
    Maven pom.xml allows dependency exclusion to include groupid=* and artifactid=* in the exclusion, which technically translates to transitive = false in Ivy world. The commit here handles that explicitly so that it doesn't lead to a ivy.xml (generated off pom.xml) to have something like:
   
           <exclude org="" module="" name="" type="" ext="*" conf="" matcher="exact"/>
   
    which effectively excludes the dependency which has this exclusion (as noted in that JIRA).
   
    The change in this commit now generates the ivy.xml as follows for such exclusions in pom.xml:
   
           <dependency org="org.owasp.esapi" name="esapi" rev="2.1.0" force="true" transitive="false" conf="compile->compile(*),master(*);runtime->runtime(*)"/>
   
    (notice the transitive=false in there)
   
    This commit also includes a test which verifies this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
   
----
commit d3b8e1906c7f33b089824a4e6f71cc98d38dc369
Author: Jaikiran Pai <[hidden email]>
Date:   2016-12-07T16:43:38Z

    IVY-1531 Fix translation of * for groupid and artifactid, in pom.xml exclusion, for implying transitive=false in ivy
   
    modified:   src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
    new file:   test/java/org/apache/ivy/core/makepom/MakePomTest.java
    modified:   test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java
    modified:   test/java/org/apache/ivy/plugins/parser/m2/test-exclusion.pom

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #10: Fix for IVY-1531

janmaterne
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...