[GitHub] ant-ivy pull request #17: Fix IVY-1478

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #17: Fix IVY-1478

bodewig
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/17

    Fix IVY-1478

    The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1478 and also includes a test case to verify the changes.
   
    The fix involves setting the unpacked artifact reference within the `ArtifactDownloadReport` when the unpacking happens. In the absence of reference to the unpacked artifact in the `ArtifactDownloadReport`, the `RetrieveEngine` while dealing with unpacked artifacts, explicitly uses the `PackagingManager` for getting hold of the unpacked artifact.
   
    This commit includes a change in the method signature of `PackagingManager.unpackArtifact` which now returns a reference to the unpacked `Artifact` whereas previously the method return type was `void`. This change however is still binary compatible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1478

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
   
----
commit 850a888c546bab897542a2d89ff76ca9debce0ee
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-18T05:55:24Z

    IVY-1478 Fix RetrieveEngine to take into account the correct extension while dealing with unpacked artifacts

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #17: Fix IVY-1478

bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]