[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

bodewig
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/19

    IVY-1554 - Add (conditional) support for SHA-256 SHA-512 and SHA-384 checksum algorithms

    The commit here adds support for SHA-256, SHA-512 and SHA-384 algorithms as requested in https://issues.apache.org/jira/browse/IVY-1554.
   
    These algorithms are added to the "known/supported algorithms", that Ivy uses to verify and publish checksums, only if the underlying Java runtime supports those. Starting Java 6 all these 3 are standard supported algorithms, but we haven't yet finalized what the minimum required Java runtime is going to be for the next Ivy release. Hence the conditional check for now.
   
    Furthermore, although the feature doesn't mandate Java 6 runtime, the testcases that I have added do require Java 6 runtime to pass. I can make those tests conditional too, but decided not to at this point. Let me know if I have to.
   
    Finally, I decided to use the algorithm keys as-is i.e. `SHA-256`, `SHA-512` and `SHA-384` instead of using aliases like we do for `SHA-1` (we use `sha1` as the checksum name there). What this effectively means for Ivy checksum verification and publishing is that the checksum files will have an extension like `original-file.SHA-256`. I haven't found any well known conventions for file name extensions for these algorithm checksum files, so I just decided to go ahead with this convention.
   
    With this commit, the complete list of supported checksum algorithms are:
   
    - md5
    - sha1
    - MD5
    - SHA-1
    - SHA-256
    - SHA-512
    - SHA-384
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1554

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
   
----
commit d8c3ef1363fd2c9d88df1093db4fe04340bedec6
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-18T10:39:06Z

    IVY-1554 Add support for SHA-256 SHA-512 and SHA-384 checksum algorithms if the underlying Java runtime supports it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]