[GitHub] ant-ivy pull request #21: Fix IVY-1495

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #21: Fix IVY-1495

apupier
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/21

    Fix IVY-1495

    The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed and the `IvySettings` instance isn't yet available for getting hold of a relevant `matcher` referred to in the `ttl` config.
   
    The commit here delays the access to the `matcher` from the `settings` instance, to when the settings instance is available.
   
    The commit also includes a test case to verify the change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1495

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
   
----
commit 0a50b2b3b5ecb67565505217876f355f74f5078f
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-19T09:00:33Z

    IVY-1495 Delay the processing of configured cache ttls, until the IvySettings object is usable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #21: Fix IVY-1495

apupier
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/21
 
    FWIW - the test failures don't look related. That specific testcase though probably needs to be looked into separately though, since it keeps failing once in a while on Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #21: Fix IVY-1495

apupier
In reply to this post by apupier
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/21
 
    >> That WarnCircularDependencyStrategyTest testcase though probably needs to be looked into separately, since it keeps failing once in a while on Jenkins.
   
    I think this https://github.com/apache/ant-ivy/pull/22 should fix the transient test failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #21: Fix IVY-1495

apupier
In reply to this post by apupier
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/21
 
    Reopening this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #21: Fix IVY-1495

apupier
In reply to this post by apupier
Github user jaikiran closed the pull request at:

    https://github.com/apache/ant-ivy/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #21: Fix IVY-1495

apupier
In reply to this post by apupier
GitHub user jaikiran reopened a pull request:

    https://github.com/apache/ant-ivy/pull/21

    Fix IVY-1495

    The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed and the `IvySettings` instance isn't yet available for getting hold of a relevant `matcher` referred to in the `ttl` config.
   
    The commit here delays the access to the `matcher` from the `settings` instance, to when the settings instance is available.
   
    The commit also includes a test case to verify the change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1495

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
   
----
commit 0a50b2b3b5ecb67565505217876f355f74f5078f
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-19T09:00:33Z

    IVY-1495 Delay the processing of configured cache ttls, until the IvySettings object is usable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #21: Fix IVY-1495

apupier
In reply to this post by apupier
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...