[GitHub] ant-ivy pull request #30: Fix transient test failures

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #30: Fix transient test failures

apupier
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/30

    Fix transient test failures

    The commit here fixes the transient test failures that we keep seeing in `WarnCircularDependencyStrategyTest`. More details about the fix are in this previous PR https://github.com/apache/ant-ivy/pull/22, but the real fix here is that we use a proper fresh `IvyContext` for each test method instead of unintentionally using the same one across test methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy logger-test-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
   
----
commit da69323b29fe8e373364b9399bc67523dcf2af62
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-20T03:43:17Z

    Fix transient test failures - Don't share/update the MockMessageLogger between test methods

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #30: Fix transient test failures

apupier
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/30
 
    Jenkins seems to have picked up the disabled Matrix job for this run. I'll wait for that to get sorted out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #30: Fix transient test failures

apupier
In reply to this post by apupier
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #30: Fix transient test failures

apupier
In reply to this post by apupier
Github user nlalevee commented on the issue:

    https://github.com/apache/ant-ivy/pull/30
 
    I don't find the fix fully satisfying because it doesn't address the fragile static set of circularDependencyId, it might produce some side effect errors in the future. At least we should keep it mind that this is a weak spot in the code.
    Nevertheless this patch nicely address the issue at hand so I merged it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...