[GitHub] ant-ivy pull request #33: More code cleanup

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #33: More code cleanup

apupier
GitHub user twogee opened a pull request:

    https://github.com/apache/ant-ivy/pull/33

    More code cleanup

    Your janitor is here again 😃
   
    This drops commons-lang as test dependency, removes unused imports, simplifies if's and corrects a bunch of misspellings.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
   
----
commit f802fa05000c92c90f4e8284b5f81c5eaad42c1a
Author: twogee <[hidden email]>
Date:   2017-05-27T14:53:01Z

    More code cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    start reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
In reply to this post by apupier
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    build.xml
    - Nice idea with the copyright statement in Javadoc ( (c)${years} ; years=tstamp("2007-yyyy") ).
   
    You found a lot of spell errors ;)
   
    MatcherLookup.java#get(Map<String,String>): new Javadoc is:
      '@return a list of matchers that can apply to module withs specified attributes'
    I am not sure about 'withs' or 'with' ...
   
    Nice rewrites of
      "myBoolean == null : false = myBoolean.booleanValue()" (and opposite) to
      "myBoolean != null && myBoolean"
   
   
   
    For Discussion:
    ---------------
    ModuleInSort.java, class javadoc, "is sorted": I think the 'iff' has a 'f' too much.
   
   
   
    Problems:
    ---------
    Fixing the spell error in DelegateHandler$ChildElementHandler (s/childHanlded/childHandled/) means breaking beakward compatiblity.
    We could introduce a delegetate for that:
      /** for BC */
      @Deprecated
      public void childHanlded(DH child) throws SAXParseException {
        childHandled(DH child);
      }
    While refactoring you have renamed all occurences in the Ivy codebase.
    On the other hand I don't know the impact (maybe outside of Ivy). I'll bring that to the dev-list.
   
    src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
   
    src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the (IMO unneccessary) ParseException. But because it is a checked Exception we break BC.
   
    renaming EncrytedProperties to EncryptedProperties means breaking BC. If required we could introduce a delegating class or a subclass.
   
    ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If required we could introduce a delegating method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
In reply to this post by apupier
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    Because of the problems I dont merge this ATM. We should discuss them on the dev list before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #33: More code cleanup

apupier
In reply to this post by apupier
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
In reply to this post by apupier
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    merged, thanks for the huge work.
    What about the "iff"? I am not a native speaker and dont want to judge ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
In reply to this post by apupier
Github user nlalevee commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    In french we have "ssi" which is a contraction of "si et seulement si" which has a mathematical meaning about absolute equivalence between two propositions.
    I bet that in english "iff" means then "if and only if".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #33: More code cleanup

apupier
In reply to this post by apupier
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
 
    You're right. I looked at a dictionary. I'll change that, so haven't to think about that in the future. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...