[GitHub] ant-ivy pull request #36: Replace emma with jacoco

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

twogee
GitHub user twogee opened a pull request:

    https://github.com/apache/ant-ivy/pull/36

    Replace emma with jacoco

    This modernises the reporting of code coverage.
    Please try it out.
    NB! On macOS, it tickles https://bugs.openjdk.java.net/browse/JDK-8022291
    which is harmless, currently slated for fix in JDK9

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
   
----
commit cf6bbf5f9b1351a9a8ac08b12c44b4fad4659f50
Author: twogee <[hidden email]>
Date:   2017-05-29T19:08:43Z

    Replace emma with jacoco

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    P.S. Any suggestions about finding out which rules do not work in Checkstyle are much appreciated. I had to resort to trial and error.
   
    Also, Ant includes a [different variant](https://github.com/apache/ant/blob/master/src/etc/checkstyle/checkstyle-frames.xsl) of `checkstyle-frames.xsl`; perhaps it would make sense to keep them in sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    The JaCoCo 'logfile' seems to be a binary one. So it should not be named '*.log'. Maybe 'jacoco-log.bin'?
   
    In 'test-report' the <fail> should be the last statement, so we get the report created.
   
    Running the jacoco:report gives me an error:
      java.lang.IncompatibleClassChangeError:
          class org.jacoco.core.internal.flow.ClassProbesVisitor has interface org.objectweb.asm.ClassVisitor as super class
      ...
      at org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1149)
      at java.lang.ClassLoader.loadClass(Unknown Source)
      at org.jacoco.ant.ReportTask.createBundle(ReportTask.java:563)
      at org.jacoco.ant.ReportTask.createReport(ReportTask.java:542)
      at org.jacoco.ant.ReportTask.execute(ReportTask.java:495)
   
    Sync: we should think about having not only the xsl in sync. Also the checkstyle rules.
   
    Finding the CS rules: I also used trial&error: deactivate all rules and activate one after the other. (maybe several at once).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    By default, jacoco "log" gets extension ".exec"; I'd rather call it ".data". I can amend the PR later tonight.
   
    Could you please check your classpath for multiple instances of asm? jacoco needs the latest asm (5.2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    JaCoCo "log" gets an extension ".data";
    JaCoCo reports are generated when JUnit fails;
    Checkstyle rules sync'ed with Ant.
    Anything else?
   
    I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    >> I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that?
   
    I believe this PR https://github.com/apache/ant-ivy/pull/37 will address that issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user nlalevee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    The build-release.xml seems to be largely modified because of some space at the end of xml tags. Could we avoid that ? It is painful to review and seems useless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    Revised accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    First progress: found an old ASM on Ant's own classpath. Ant 1.9.6 loads that via fetch.xml. Different topic ...
   
    JaCoCo runs fine. Report generation failed without any hint. Try running with -debug ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    There are reports about the "log" file getting corrupt when it accumulates results from multiple runs. If 'ant clean' helps, then perhaps the "log" file must be removed in test-internal target before any tests are executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    Stacktrace is:
    C:\projekte\apache-ant\ivy-core\build.xml:492: Error while creating report
            at org.jacoco.ant.ReportTask.execute(ReportTask.java:501)
    Caused by: java.io.IOException: Error while analyzing org\apache\ivy\Ivy$1.class.
            at org.jacoco.core.analysis.Analyzer.analyzerError(Analyzer.java:155)
    Caused by: java.lang.IllegalStateException: Can't add different class with same name: org/apache/ivy/Ivy$1
            at org.jacoco.core.analysis.CoverageBuilder.visitCoverage(CoverageBuilder.java:107)
   
    I'll try a clean+test-report ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    While not having the result of the clean-run, what about deleting the jacoco.data file just before running <jacoco>?
   
    With ASM I could spend a little bit to do a check before ... (something like: rc = all jars with name = *asm*.jar and a loadable ASM.class; if rc.length>1 fail)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    Adressed the deletion by myself.
    Left the ASM over for another time.
    Merge all ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #36: Replace emma with jacoco

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/36
 
    Thanks! BTW I had to keep the "test-coverage" target as an alias because that's what the Jenkins scripts expect. That's another adjustment for later...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...