[GitHub] ant-ivy pull request #37: Don't pollute the source lib folder during ivy ret...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #37: Don't pollute the source lib folder during ivy ret...

bodewig
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/37

    Don't pollute the source lib folder during ivy retrieval in test

    The `IvyRetrieveBuildFileTest` triggers a Ant project build during the test case and issues a `ivy:retrieve` through the build file. The retrieve ends up putting these test files (some of which are dummy files) into the `${lib.dir}` of the project source and causes issues like the one noted in https://github.com/apache/ant-ivy/pull/36
   
    >> I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that?
   
    The commit in this PR fixes that issue to use a test build specific directory to retrieve these test specific artifacts.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy lib-pollution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
   
----
commit cb91a10627d2e68bae924e425ad6f21353f5bf94
Author: Jaikiran Pai <[hidden email]>
Date:   2017-05-31T07:43:28Z

    Don't pollute the source lib folder during ivy retrieval in test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #37: Don't pollute the source lib folder during ivy retrieval ...

bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/37
 
    Thanks, could this PR be merged? Then I'll clean up #36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #37: Don't pollute the source lib folder during ivy ret...

bodewig
In reply to this post by bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #37: Don't pollute the source lib folder during ivy retrieval ...

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/37
 
    :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]