[GitHub] ant-ivy pull request #41: Checkstyle

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #41: Checkstyle

twogee
GitHub user twogee opened a pull request:

    https://github.com/apache/ant-ivy/pull/41

    Checkstyle

    Now that checkstyle rules are sync'ed with Ant, here come the consequences 😃
    I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant-ivy checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
   
----
commit 838aa1bd37ff2f60a51c60969204964839937eb9
Author: twogee <[hidden email]>
Date:   2017-06-02T15:37:04Z

    first batch of SVG replacements

commit 57ee0f2d15768efd10c15c7ef14da8a7db94deaa
Author: twogee <[hidden email]>
Date:   2017-06-03T07:58:10Z

    Inline warning icon

commit 1ca5f08e25401ad9861d6de333f8e53791384be6
Author: twogee <[hidden email]>
Date:   2017-06-03T09:42:00Z

    Checkstyle-driven cleanup (whitespace, javadoc, JLS)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #41: Checkstyle

twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/41
 
    There a bunch of new image files (svg, ...) I dont think that this is related to 'checkstyle'.
   
    The other files:
    - remove trailing spaces
    - add required 'final' to parameters
    - add javadoc
    - ordering of modifiers
   
    Have to think about the images. The rest is fine for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #41: Checkstyle

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/41
 
    The SVGs shouldnt contain the "Generator" comment, I'll fix that.
   
    *.odg? OpenOffice Draw? Maybe we should place a readme into doc/images how to create/modify a SVG ("use Draw, Export ....")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #41: Checkstyle

twogee
In reply to this post by twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/41
 
    I found a comment in hibgraph.svg: "Helvetica is a registered trademark of Linotype AG".
    I am not sure about using that in an Apache project ...
    I'll forward this to the dev llist. Maybe to [hidden email] later ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #41: Checkstyle

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/41
 
    Some of the SVGs are produced by directly by yEd. I guess they're the ones that miss "Generator". I'll check them and amend accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy issue #41: Checkstyle

twogee
In reply to this post by twogee
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/41
 
    Sorry about the mess, #41 got conflated with #39.
    It's due my inexperience, #39 is on master and #41 is on a branch of it's own in my repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant-ivy pull request #41: Checkstyle

twogee
In reply to this post by twogee
Github user twogee closed the pull request at:

    https://github.com/apache/ant-ivy/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...