[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

bodewig
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/44

    IVY-1561 - Enhancement to take into account environment and system properties while evaluation Maven pom property references

    The commit in this PR introduces the enhancement requested in https://issues.apache.org/jira/browse/IVY-1561 and includes a test case to verify it.
   
    Maven allows developers to refer to system properties and environment variables in the pom.xml file and those properties (of the form `${property}`) are evaluated by Maven by taking into account any environment variables or system properties set during that run.
   
    Ivy, while creating a module descriptor out of pom.xml, didn't so far have this ability to account for environment variables and system properties while evaluating pom properties. The commit here introduces that ability.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1561

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
   
----
commit c07d659cf8f7b16452472da6052a1de326bcb6a4
Author: Jaikiran Pai <[hidden email]>
Date:   2017-06-13T05:27:53Z

    IVY-1561 Take into account environment variable and system properties while evaluating property references in Maven pom.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant-ivy/pull/44


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #44: IVY-1561 - Enhancement to take into account environment a...

bodewig
In reply to this post by bodewig
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/44
 
    merged, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]