[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

bodewig
GitHub user twogee opened a pull request:

    https://github.com/apache/ant-ivy/pull/45

    Generics + foreach loops and Java 7 in util (except Filter)

    Sorry for another largish commit, but I don't see much sense splitting it, either.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
   
----
commit 7ed8f551afeaa6352999f1a2997e16164a29075c
Author: twogee <[hidden email]>
Date:   2017-06-14T19:19:50Z

    Generics + foreach loops and Java 7 in util (except Filter)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

bodewig
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/45
 
    Thanks for the PR. Merged.
   
    P.S: Someone else will have to close this PR, till I understand how I can auto-close this or get access to a close button.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/45
 
    I pushed new commits which ended up in this PR 😈
    This adds more generics in ant and tools, only core and plugins left 😃
   
    To dispel all scares about generics I added a binary compatibility test.
    My choice was between japicmp and revapi.
    The latter has an Ant task (with broken dependencies), but requires Java 8.
    The former works with Java 7 (thanks to Guava), but my JavaScript hack requires Nashorn.
    Therefore, the target is standalone and can be run as 'ant revapi' (a wink to my first choice).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/45
 
    I'll put japicmp into a separate PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

bodewig
In reply to this post by bodewig
Github user twogee closed the pull request at:

    https://github.com/apache/ant-ivy/pull/45


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]