[GitHub] ant-ivy pull request #69: 2.4.x

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy pull request #69: 2.4.x

bodewig
GitHub user supertick opened a pull request:

    https://github.com/apache/ant-ivy/pull/69

    2.4.x

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/supertick/ant-ivy 2.4.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
   
----
commit f9e51f56a5d4115d00af10bc1404217805f89455
Author: grperry <grperry@...>
Date:   2018-03-18T22:07:09Z

    re-use standalone ivy interface for programmatic one

commit 8f473734f05eb99568db4c5675f7b892337852b0
Author: grperry <grperry@...>
Date:   2018-03-18T22:26:50Z

    backed out windows crlf

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    Could you please provide a unit test to demonstrate what is wrong with [IVY-1576 fix](https://github.com/apache/ant-ivy/commit/3b17df0ab67a1f14794bc6c60b735f3354caec9e)?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    I suggest closing this PR. The main problem here is that programmatic use should not be adressed by adding CLI options which make no sense. Also, if resolve() ends with errors, it's best to throw an exception encapsulating whatever relevant information is available, rather than blithely carrying on.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user supertick commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    I think it would be great "not" to have an additional CLI option, but then you cannot have a System.exit(1) terminating the client code (https://github.com/apache/ant-ivy/blob/2.4.x/src/java/org/apache/ivy/Main.java#L313) just because of an error.
   
    The errors (and the successes) can be queried out of the ResolveReport.  A client can programmatically make decisions based on the data returned. And the run() methods still throw their respective exceptions which could be caught by the client consumer.
   
    The new option is to alleviate the problematic design of having an error terminate a client consumer  with a System.exit.
   
    Perhaps a design would be to copy/paste Main.java to IvyClient.java and remove the System.exit - but then it would be less normalized, which has its own flaws.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user wordlessly commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    I also spam this pull request. (why not open issue tracker here?)
   
   
    Ivy CLI says: -types <types>               comma separated list of accepted artifact types
   
    java -jar ivy-2.4.0.jar -cache ./ivy -types source,jar ...
   
    does NOT work. What does work is a white space separated list of artifacts.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    Issue tracker for the project is [JIRA](https://issues.apache.org/jira). Apache has own Git infrastructure, GitHub is use to increase exposure and as easy means to suggest code changes (rather than uploading patches).
   
    Please check the [latest](https://ant.apache.org/nightlies.html) Ivy build. I cannot verify your report right now, but the value of types should be split [correctly](https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/util/filter/FilterHelper.java#L37) in master.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    @supertick FYI, Ivy 2.5.0 RC is on the way, @nlalevee has kindly taken the role of release manager. Your latest commits are not merged to master, though. If you are interested in using 2.5.0, please let us know.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user sutchark commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    How should we let you know? Here?
   
    I am interested in using 2.5.0.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant-ivy issue #69: 2.4.x

bodewig
In reply to this post by bodewig
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/69
 
    Check out the [nightlies](https://ant.apache.org/nightlies.html)
    I was commenting here because @supertick is apparently pushing changes to 2.4.x release branch, but the RC is from the master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]