Quantcast

[GitHub] ant pull request #25: fix problems with argument handling of trailing space ...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant pull request #25: fix problems with argument handling of trailing space ...

janmaterne
GitHub user jwadamson opened a pull request:

    https://github.com/apache/ant/pull/25

    fix problems with argument handling of trailing space and sed/echo quirks

    So this is where I have landed through trial and error on improving the argument handling code.
   
    Tested with:
     mac bsd_sed+bash
     ubuntu gnu_sed+dash
     ubuntu gnu_sed+ksh93
     ubuntu gnu_sed+zsh
   
    We should ask mailing list to test on default Solaris, AIX, and HPUX platforms.
    If they experience problems due to sed versions, they can test out awk as an esc_tool alternative value. If neither works consistently we can add some bash/zsh/ksh93 detection to use a bashism when available to avoid sed and awk when possible..
   
    Attached is a manual test.sh and test.xml which echos some passed in properties to demonstrate correct handling of special characters and whitespace/newline scenarios.
    [test.zip](https://github.com/apache/ant/files/536763/test.zip)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwadamson/ant-1 fix-60150_1.9.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
   
----
commit b5443219ceabe6773eb9f3f47bca7d6c111a0dd2
Author: Jeffrey Adamson <[hidden email]>
Date:   2016-10-10T21:16:27Z

    fix problems with argument handling of trailing space and sed/echo quirks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant pull request #25: fix problems with argument handling of trailing space ...

janmaterne
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant issue #25: fix problems with argument handling of trailing space and sed...

janmaterne
In reply to this post by janmaterne
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/25
 
    Thanks, Jeff, I've merged your changes. Let's hope people with access to the more problematic OSes give it a try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant issue #25: fix problems with argument handling of trailing space and sed...

janmaterne
In reply to this post by janmaterne
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/25
 
    oh no! https://bz.apache.org/bugzilla/show_bug.cgi?id=60562
   
    will there ever be an end to this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant issue #25: fix problems with argument handling of trailing space and sed...

janmaterne
In reply to this post by janmaterne
Github user jwadamson commented on the issue:

    https://github.com/apache/ant/pull/25
 
    It seems not. :-(
    Solaris, when matching posix spec isn't enough.
   
    I'm going to try to get up to speed on current state if I can. This is just maddening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...