[GitHub] ant pull request #29: detect solaris 10 to avoid certain POSIX expressions

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #29: detect solaris 10 to avoid certain POSIX expressions

bodewig
GitHub user jwadamson opened a pull request:

    https://github.com/apache/ant/pull/29

    detect solaris 10 to avoid certain POSIX expressions

    Another attempt at fixing for solaris without regressing POSIX platforms.
   
    1) use `uname` to detect solaris 10 platform.  Could not figure out a way via feature-detection to make change specific to the heirloom-sh found on it. Can be overridden via env PROTECT_NL=true|false.
    2) esc_arg sed line is now done with `` instead of $(), due to heirloom compatibility.
    3) ant_exec_debug final printing should have used printf instead of echo for accuracy of output
    4) padding protection only was needed on the end of the processing argument and only for non-heirloom.
   
   
    I tested with arguments for empty-string and the 6 most special characters (dollar, double-quote, backtick, singlequote, backslash, newline):
   
    --execdebug -version '' '$' '"' '`' "'" '\\' '
    '
   
    Worked on ubuntu 14.04, and with Solaris 10 with the caviat newlines get trimmed from arguments on Solaris 10 e.g. the newline-only argument was translated into an empty-string.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwadamson/ant-1 1.9.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
   
----
commit 2b2e4b8bc4038cbdd1a01451d1fdd5fee1edd262
Author: Jeffrey Adamson <[hidden email]>
Date:   2017-01-13T16:16:45Z

    detect solaris 10 to avoid certain POSIX expressions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #29: detect solaris 10 to avoid certain POSIX expressions

bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #29: detect solaris 10 to avoid certain POSIX expressions

bodewig
In reply to this post by bodewig
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/29
 
    Many thanks again, Jeff


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]