[GitHub] ant pull request #34: eblikstad

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant pull request #34: eblikstad

twogee
GitHub user eblikstad opened a pull request:

    https://github.com/apache/ant/pull/34

    eblikstad

    Hi
   
    I have created a workaround for Windows regarding redirection of I/O. Several win32 console programs do not handle a closed input. Ref. https://bz.apache.org/bugzilla/show_bug.cgi?id=61153
   
    Regards,
    Espen Blikstad

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eblikstad/ant ANT_18_BRANCH

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
   
----
commit 7370f0889031b34c0693273077fbbb985e998e93
Author: eblikstad <[hidden email]>
Date:   2017-06-04T18:21:43Z

    Added exception for Windows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant issue #34: eblikstad

twogee
Github user janmaterne commented on the issue:

    https://github.com/apache/ant/pull/34
 
    Thanks for the PR. The first view:
    * there isnt any test (not sure it would be possible)
    * baseline is Ant_1.8, which is not maintained any more.
    Current Ant is 1.9 for Java5 and Ant 1.10 for Java8, see http://ant.apache.org/faq.html#java-version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...