[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

apupier
GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant/pull/35

    [1.9.x branch] Fix for BZ-43271 BZ-59648

    The commit here fixes the issue reported in:
   
    https://bz.apache.org/bugzilla/show_bug.cgi?id=43271#c6
    https://bz.apache.org/bugzilla/show_bug.cgi?id=59648
   
    This commit now checks the target remote path to determine the correct remote path before issuing a `chmod` with configured `fileMode` permissions.
   
    I have tested this _manually_ using the `scp` task but I don't have any access to systems or testcases to make sure this works for SFTP and such.
   
    P.S: This PR is against 1.9.x branch. If necessary I can even create a separate PR for master branch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant bz-59648

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
   
----
commit 57f7d00f9765cb7e3485385eef7bffab6b9d2e9b
Author: Jaikiran Pai <[hidden email]>
Date:   2017-07-22T08:59:59Z

    BZ-43271 BZ-59648 Change permissions on the correct remote file (path) that was transferred, instead of accidentally changing the permissions of the directory containing the transferred file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant issue #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

apupier
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/35
 
    All done - applied this commit to 1.9.x branch and then merged to master branch. The pushed commit also includes updates to the WHATSNEW and contributor files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

apupier
In reply to this post by apupier
Github user jaikiran closed the pull request at:

    https://github.com/apache/ant/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...