[GitHub] ant pull request #36: Allow faking of zip entry modification times.

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #36: Allow faking of zip entry modification times.

bodewig
GitHub user GKFX opened a pull request:

    https://github.com/apache/ant/pull/36

    Allow faking of zip entry modification times.

    Adds DateUtils.parseLenientDateTime. Discussed in mailing list thread "Reproducible JARs".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GKFX/ant feature-reproduciblebuilds

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
   
----
commit 83e8a61e6acf8a8ad71cacd039a0c87081df74af
Author: George Bateman <[hidden email]>
Date:   2017-08-28T11:20:38Z

    Allow faking of zip entry modification times.
   
    Adds DateUtils.parseLenientDateTime.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/36
 
    Many thanks @GKFX
   
    I think we don't want to make `DateUtils` depend on `Touch` but rather have it the other way around. Could you please move the definition of `DEFAULT_DF_FACTORY` to `DateUtils` and have the field in `Touch` read it's value from `DateUtils`?
   
    Tests would be nice ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user GKFX commented on the issue:

    https://github.com/apache/ant/pull/36
 
    Will do, hopefully in a few days.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user GKFX commented on the issue:

    https://github.com/apache/ant/pull/36
 
    @bodewig I've done that, but `ant test` fails with the output
    ```
    -antunit-warn-location:
         [echo] AntUnit tests must be run with /home/bateman/Geek/ant/bootstrap (or /home/bateman/Geek/ant/dist), not /usr/share/ant. Try './build.sh antunit-tests' for example.
   
    antunit-tests:
   
    BUILD FAILED
    /home/bateman/Geek/ant/build.xml:1957: Problem: failed to create task or type antlib:org.apache.ant.antunit:antunit
    Cause: The name is undefined.
    Action: Check the spelling.
    Action: Check that any custom tasks/types have been declared.
    Action: Check that any <presetdef>/<macrodef> declarations have taken place.
    No types or tasks have been defined in this namespace yet
   
    This appears to be an antlib declaration.
    Action: Check that the implementing library exists in one of:
            -/usr/share/ant/lib
            -/home/bateman/.ant/lib
            -a directory added on the command line with the -lib argument
    ```
    and I'm not quite sure how to fix that. Is the test I've written wrong?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user janmaterne commented on the issue:

    https://github.com/apache/ant/pull/36
 
    ant-unit-1.3 is in the repo (https://github.com/apache/ant/blob/master/lib/optional/ant-antunit-1.3.jar).
    It seems that you use an Ant version for building this which does not contain this jar.
   
    If you are building Ant itself I recommend cleaning the environment before (unset ANT_HOME) and bootstrap Ant by itself.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/36
 
    @GKFX really do as the error message says and run `./build.sh test` or `build.bat test` depending on your platform from inside the Ant source tree. The wrapper script will ensure you have all the required libraries on your classpath.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user GKFX commented on the issue:

    https://github.com/apache/ant/pull/36
 
    Thank you, that all worked great. Hopefully that's ready to merge.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/36
 
    Looks great, many thanks! I'll merge it to both branches and add `@since` markers.
   
    We'll need to update the manual (probably of zip, jar, war and ear). Also some additional unit tests for `parseLenient` would be good (good old JUnit tests). If you want to take a stab at either, please do so in a fresh PR. Otherwise I'll carve out some time to do it myself.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/36


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #36: Allow faking of zip entry modification times.

bodewig
In reply to this post by bodewig
Github user GKFX commented on the issue:

    https://github.com/apache/ant/pull/36
 
    @bodewig Great, I'll have a shot at the parseLenient tests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]