[GitHub] ant pull request #57: Make junitreport with Saxon

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #57: Make junitreport with Saxon

twogee
GitHub user adamretter opened a pull request:

    https://github.com/apache/ant/pull/57

    Make junitreport with Saxon

    Previously the XSLT(s) used in `junitreport` were only compatible with Xalan 2. Whilst you could specify a different `TransformerFactory`, and that could be Saxon, it would fail as the XSL(s) use Xalan specific extensions.
   
    This PR adds compatibility with Saxon, so that if you specify Saxon as the `TransformerFactory`, then pure XSLT2 stylesheets are used without any vendor extensions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adamretter/ant junitreport-xsl-saxon

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
   
----
commit 3ceba3aaf66701aad8fc4a8ad685df4e6645a2c9
Author: Adam Retter <adam.retter@...>
Date:   2018-02-04T10:09:55Z

    [bugfix] Allow Saxon to be used for junitreport XSL transformation

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/57
 
    this is ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/31/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/37/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/57
 
    @adamretter The test failure https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/ looks related to this change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/39/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/57
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/33/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/57
 
    Looks good to me. If @bodewig doesn't have any concerns with this change, I'll go ahead and merge this, this week.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/57
 
    Looks good, thanks @adamretter
   
    I don't think the WiX configuration really is current as we don't use it - it used to be an experiment many years ago that we never completed. Updating it won't hurt, though.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/57


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/57
 
    @adamretter, this is now merged and we have added your name (Adam Retter) to our contributors list. If you want us to a use different name or not include the name at all, please do let us know.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user adamretter commented on the issue:

    https://github.com/apache/ant/pull/57
 
    @jaikiran So er, this doesn't seem to be in the 1.10.2 release?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/57
 
    @adamretter the PR was merged too late for 1.10.2, it is part of the 1.10.3 release candidate we are currently voting on.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #57: Make junitreport with Saxon

twogee
In reply to this post by twogee
Github user adamretter commented on the issue:

    https://github.com/apache/ant/pull/57
 
    @bodewig Ah okay cool. Thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]