[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

twogee
GitHub user reudismam opened a pull request:

    https://github.com/apache/ant/pull/61

    Use the isEmpty method instead of comparing the value of size() to 0.

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reudismam/ant size

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
   
----
commit 25315d0c28cf81c8c23944d3f368c76c6da02ac2
Author: reudismam <reudismam@...>
Date:   2018-02-15T17:30:25Z

    Use the isEmpty method instead of comparing the value of size() to 0.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/61
 
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/61
 
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/61
 
    this is ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/61
 
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/61
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/36/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/61
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/42/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

twogee
In reply to this post by twogee
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/61


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

twogee
In reply to this post by twogee
Github user jaikiran commented on the issue:

    https://github.com/apache/ant/pull/61
 
    Thank for you the PR. This is now merged



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]