[GitHub] ant pull request #63: Replace JAI with ImageIO

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #63: Replace JAI with ImageIO

jaikiran
GitHub user twogee opened a pull request:

    https://github.com/apache/ant/pull/63

    Replace JAI with ImageIO

    Undeprecate Image task in Java 9+. No documentation yet; only the code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant image-with-imageio

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
   
----
commit 7930191ba5300eeccd6a021b9ae6f7e616482ffe
Author: twogee <g.grigelionis@...>
Date:   2018-07-06T19:03:13Z

    Replace JAI with ImageIO

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/67/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/61/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/63
 
    I'm a bit torn as this PR breaks public APIs and may break build environments where somebody has managed to install JAI. for example because they've downloaded it long ago. Maybe it would be better to make this a new task so people can actively chose the implementation.
   
    Also note we have deprecated the Java classes but the image task's manual doesn't mention deprecation at all.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user twogee commented on the issue:

    https://github.com/apache/ant/pull/63
 
    JAI is dead. It depends on internal classes that are no longer there in Java 9. I propose dropping JAI API support completely, just like apt or javah. I don't like the like the idea of shipping dead code for the sake of BWC. If someone would like to use JAI on Java 8, there is an option of using an older ant-jai.jar; else, [jai-imageio-core](https://jai-imageio.github.io/jai-imageio-core/) implements the lacking functionality (TIFF support). Also, there are [TwelveMonkeys](https://haraldk.github.io/TwelveMonkeys/) for even more functionality.
   
    The task is not deprecated in documentation because it works on Java 8 as is; perhaps the situation with JAI should be explained once there's an agreement on how to proceed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/63
 
    My scenario is people using Java 8, where JAI still works - Java 8 is far less dead than Java 9 in my view :-)
   
    I'd prefer a new "imageio" (or whatever it is called) task that doesn't suggest it was a drop-in replacement.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user twogee commented on the issue:

    https://github.com/apache/ant/pull/63
 
    "imageio" is fine by me, then we skip a potential debacle about naming of java-jai.jar 😉
    Whenever JAI is laid to rest, "image" can be reclaimed as an alias.
    FWIW Java 8 is an LTS release, but hopefully not the last one.
   
    So, it's refactoring, fixing build.xml, writing the documentation and putting a note about JAI in Image task manual -- did I miss something?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/68/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/62/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user bodewig commented on a diff in the pull request:

    https://github.com/apache/ant/pull/63#discussion_r201577768
 
    --- Diff: build.xml ---
    @@ -277,13 +277,20 @@
         <filename name="${optional.package}/ANTLR*"/>
       </selector>
     
    +  <selector id="needs.imageio">
    +    <or>
    +      <filename name="${optional.package}/image/ImageIO*"/>
    +      <filename name="${optional.type.package}/imageio/"/>
    +    </or>
    +  </selector>
    +
       <selector id="needs.jmf">
         <filename name="${optional.package}/sound/"/>
       </selector>
     
       <selector id="needs.jai">
         <or>
    -      <filename name="${optional.package}/image/"/>
    +      <filename name="${optional.package}/image/Image.*"/>
    --- End diff --
   
    You also need to add ImageTest here as the selector is also used when deciding which tests to run (this probabl explains the Jenkins build failures).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/63
 
    Looks as if only the manual was missing. :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Windows/69/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/63
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/Ant%20Github-PR-Linux/63/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user twogee commented on a diff in the pull request:

    https://github.com/apache/ant/pull/63#discussion_r201826479
 
    --- Diff: build.xml ---
    @@ -277,13 +277,20 @@
         <filename name="${optional.package}/ANTLR*"/>
       </selector>
     
    +  <selector id="needs.imageio">
    +    <or>
    +      <filename name="${optional.package}/image/ImageIO*"/>
    +      <filename name="${optional.type.package}/imageio/"/>
    +    </or>
    +  </selector>
    +
       <selector id="needs.jmf">
         <filename name="${optional.package}/sound/"/>
       </selector>
     
       <selector id="needs.jai">
         <or>
    -      <filename name="${optional.package}/image/"/>
    +      <filename name="${optional.package}/image/Image.*"/>
    --- End diff --
   
    Thanks, Stefan, on to the documentation...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user twogee commented on the issue:

    https://github.com/apache/ant/pull/63
 
    I could almost reuse the class diagram in the documentation if it wasn't referring to PlanarImage... so I have to draw a new one unless the original UML is available somewhere (a long shot, I know...)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] ant issue #63: Replace JAI with ImageIO

jaikiran
In reply to this post by jaikiran
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/63
 
    or live without any UML diagram :-) - no, I don't think we've got anything but the image.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]