[GitHub] ant pull request #:

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #:

bodewig
Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28586872
 
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java on line 117:
    This test is ignored anyway, but your change doesn't seem correct.
   
    The original code does not expect a `RuntimeException` always - there is no `fail` inside the try block. It has an assertion that is only expected to hold true if there is no `RuntimeException` (so it may be wrong in the `finally` block) and an assertion about the exception if one occurs at all.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]