[GitHub] ant pull request #:

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #:

bodewig
Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688418
 
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
    Aren't we missing the `fails` for the second and third call to `findClass` with `expectException`? I may be wrong, but I think the rule will be satisfied if the first call throws an exception and the test will happily pass even if the remaining calls don't.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]