[GitHub] ant pull request #:

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ant pull request #:

twogee
Github user twogee commented on the pull request:

    https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469
 
    In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java:
    In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java on line 77:
    Please add 20 (package), too


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] ant pull request #:

Jaikiran Pai
I did plan to addit yesterday, but my local tests did not trigger the
package-info constant pool entry for some reason. So I decided to not
rush it in and spend some time to get the test right, to make sure it
works fine. I'll add it in either tonight or tomorrow once I get to see
what's going on.

-Jaikiran


On 12/05/18 9:19 PM, twogee wrote:

> Github user twogee commented on the pull request:
>
>      https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469
>    
>      In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java:
>      In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java on line 77:
>      Please add 20 (package), too
>
>
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] ant pull request #:

Gintautas Grigelionis
Thanks, great work! I hope you don't mind me taking the liberty to adjust
WHATSNEW.

Gintas

2018-05-13 6:01 GMT+02:00 Jaikiran Pai <[hidden email]>:

> I did plan to addit yesterday, but my local tests did not trigger the
> package-info constant pool entry for some reason. So I decided to not rush
> it in and spend some time to get the test right, to make sure it works
> fine. I'll add it in either tonight or tomorrow once I get to see what's
> going on.
>
> -Jaikiran
>
>
>
> On 12/05/18 9:19 PM, twogee wrote:
>
>> Github user twogee commented on the pull request:
>>
>>      https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b6
>> 79705c2f2164426e7e6fb#commitcomment-28953469
>>         In src/main/org/apache/tools/ant/taskdefs/optional/depend/const
>> antpool/ConstantPoolEntry.java:
>>      In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java
>> on line 77:
>>      Please add 20 (package), too
>>
>>
>> ---
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] ant pull request #:

Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind.

-Jaikiran


On 13/05/18 1:03 PM, Gintautas Grigelionis wrote:

> Thanks, great work! I hope you don't mind me taking the liberty to adjust
> WHATSNEW.
>
> Gintas
>
> 2018-05-13 6:01 GMT+02:00 Jaikiran Pai <[hidden email]>:
>
>> I did plan to addit yesterday, but my local tests did not trigger the
>> package-info constant pool entry for some reason. So I decided to not rush
>> it in and spend some time to get the test right, to make sure it works
>> fine. I'll add it in either tonight or tomorrow once I get to see what's
>> going on.
>>
>> -Jaikiran
>>
>>
>>
>> On 12/05/18 9:19 PM, twogee wrote:
>>
>>> Github user twogee commented on the pull request:
>>>
>>>       https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b6
>>> 79705c2f2164426e7e6fb#commitcomment-28953469
>>>          In src/main/org/apache/tools/ant/taskdefs/optional/depend/const
>>> antpool/ConstantPoolEntry.java:
>>>       In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java
>>> on line 77:
>>>       Please add 20 (package), too
>>>
>>>
>>> ---
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]