Ivy expertise needed for Bug 65110

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Ivy expertise needed for Bug 65110

Stefan Bodewig
Hi

https://bz.apache.org/bugzilla/show_bug.cgi?id=65110

when creating and publishing an Ant release we seem to create empty
source jars for ant-testutil - and only for that. The most obvious
difference that sets it apart from the other artifacts is that its
sources live in src/test not src/main.

Creating source jars using our POM and "mvn source:jar" creates the jar
I'd expect. So I assume Ivy is doing something different from Maven -
and here I'm way out of my depth WRT Ivy.

HELP! :-)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ivy expertise needed for Bug 65110

Jaikiran Pai
Hello Stefan,

I can take a look at it later tonight and see what's going on.

-Jaikiran

On 28/01/21 2:21 pm, Stefan Bodewig wrote:

> Hi
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=65110
>
> when creating and publishing an Ant release we seem to create empty
> source jars for ant-testutil - and only for that. The most obvious
> difference that sets it apart from the other artifacts is that its
> sources live in src/test not src/main.
>
> Creating source jars using our POM and "mvn source:jar" creates the jar
> I'd expect. So I assume Ivy is doing something different from Maven -
> and here I'm way out of my depth WRT Ivy.
>
> HELP! :-)
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ivy expertise needed for Bug 65110

Jaikiran Pai
In reply to this post by Stefan Bodewig
Hello Stefan,

I had a quick look and to me this looks like a bug in our build.xml
itself and not related to Ivy. The source jar for testutil gets
generated as part of our Ant "test-jar-source" which is using a wrong
directory to find the testutil sources. I have opened a PR
https://github.com/apache/ant/pull/143 which seems to fix that issue. I
didn't commit it directly because I came up with this fix in a hurry and
haven't done much testing other than making sure the
testutil-sources.jar now has the correct content.


-Jaikiran

On 28/01/21 2:21 pm, Stefan Bodewig wrote:

> Hi
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=65110
>
> when creating and publishing an Ant release we seem to create empty
> source jars for ant-testutil - and only for that. The most obvious
> difference that sets it apart from the other artifacts is that its
> sources live in src/test not src/main.
>
> Creating source jars using our POM and "mvn source:jar" creates the jar
> I'd expect. So I assume Ivy is doing something different from Maven -
> and here I'm way out of my depth WRT Ivy.
>
> HELP! :-)
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ivy expertise needed for Bug 65110

Jaikiran Pai
I've now committed that change to both master and 1.9.x branches upstream.

-Jaikiran

On 28/01/21 4:22 pm, Jaikiran Pai wrote:

> Hello Stefan,
>
> I had a quick look and to me this looks like a bug in our build.xml
> itself and not related to Ivy. The source jar for testutil gets
> generated as part of our Ant "test-jar-source" which is using a wrong
> directory to find the testutil sources. I have opened a PR
> https://github.com/apache/ant/pull/143 which seems to fix that issue.
> I didn't commit it directly because I came up with this fix in a hurry
> and haven't done much testing other than making sure the
> testutil-sources.jar now has the correct content.
>
>
> -Jaikiran
>
> On 28/01/21 2:21 pm, Stefan Bodewig wrote:
>> Hi
>>
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=65110
>>
>> when creating and publishing an Ant release we seem to create empty
>> source jars for ant-testutil - and only for that. The most obvious
>> difference that sets it apart from the other artifacts is that its
>> sources live in src/test not src/main.
>>
>> Creating source jars using our POM and "mvn source:jar" creates the jar
>> I'd expect. So I assume Ivy is doing something different from Maven -
>> and here I'm way out of my depth WRT Ivy.
>>
>> HELP! :-)
>>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ivy expertise needed for Bug 65110

Stefan Bodewig
In reply to this post by Jaikiran Pai
On 2021-01-28, Jaikiran Pai wrote:

> I had a quick look and to me this looks like a bug in our build.xml
> itself and not related to Ivy.

My bad. I must admit I really don't know much about Ivy at all and
forgot how the jars we publish get prepared. I assumed Ivy was using our
poms, which it obviously does not.

Thank you for taking care of this

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Ivy expertise needed for Bug 65110

Gintautas Grigelionis
On Fri, 29 Jan 2021 at 08:59, Stefan Bodewig <[hidden email]> wrote:

> On 2021-01-28, Jaikiran Pai wrote:
>
> > I had a quick look and to me this looks like a bug in our build.xml
> > itself and not related to Ivy.
>
> My bad. I must admit I really don't know much about Ivy at all and
> forgot how the jars we publish get prepared. I assumed Ivy was using our
> poms, which it obviously does not.
>
> Thank you for taking care of this
>
> Stefan
>

I had a proposal to use only Ivy (which requires 2.5.0 for SHA checksums).
I can complete that, if it is of interest.

Gintas