Re: [2/2] ant git commit: Checkstyle/spelling

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] ant git commit: Checkstyle/spelling

Stefan Bodewig
On 2018-04-20, <[hidden email]> wrote:

> http://git-wip-us.apache.org/repos/asf/ant/blob/5f4c43dd/src/main/org/apache/tools/ant/taskdefs/email/Message.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/ant/taskdefs/email/Message.java b/src/main/org/apache/tools/ant/taskdefs/email/Message.java
> index 0b763e4..ec10e99 100644
> --- a/src/main/org/apache/tools/ant/taskdefs/email/Message.java
>>>> b/src/main/org/apache/tools/ant/taskdefs/email/Message.java
> @@ -109,15 +109,13 @@ public class Message extends ProjectComponent {
>       * @param ps The print stream to write to
>       * @throws IOException if an error occurs
>       */
> -    public void print(PrintStream ps)
> -         throws IOException {
> +    public void print(PrintStream ps) throws IOException {
>          // We need character encoding aware printing here.
>          // So, using BufferedWriter over OutputStreamWriter instead of PrintStream
>          BufferedWriter out = null;
>          try {
> -            out
> -                = charset != null ? new BufferedWriter(new OutputStreamWriter(ps, charset))
> -                : new BufferedWriter(new OutputStreamWriter(ps));
> +            out = charset == null ? new BufferedWriter(new OutputStreamWriter(ps))
> +                    : new BufferedWriter(new OutputStreamWriter(ps, charset));
>              if (messageSource != null) {
>                  // Read message from a file
>                  try (Reader freader = getReader(messageSource);

I'm sorry, this is part of a commit with a diff of 1800 lines and this
change - moving around a few line breaks, swapping a condition - doesn't
help anybody. It doesn't make the code better in any way, it doesn't get
more or less readable or more robust or whatever. I'd really really
prefer to not have to review this kind of change to a source code that
has no other changes at all.

Gintas, please restrict yourself to cosmetic changes in places that you
really intend to make substantial changes to or - even better - just
don't perform them at all.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]