Re: ant git commit: Remove redundancies

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: ant git commit: Remove redundancies

Stefan Bodewig

> diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java b/src/main/org/apache/tools/ant/types/PatternSet.java

> -                : new StringBuilder(baseString).append(";encoding->").append(encoding).toString();
> +                : baseString + ";encoding->" + encoding;

I don't understand what kind of redundancy have you been removing here.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: ant git commit: Remove redundancies

Matt Sicker
Pretty much every implementation of javac will automatically convert the
string concatenation code into StringBuilders. Decompile the byte code and
see for yourself.

On Tue, 21 Aug 2018 at 13:05, Stefan Bodewig <[hidden email]> wrote:

>
> > diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java
> b/src/main/org/apache/tools/ant/types/PatternSet.java
>
> > -                : new
> StringBuilder(baseString).append(";encoding->").append(encoding).toString();
> > +                : baseString + ";encoding->" + encoding;
>
> I don't understand what kind of redundancy have you been removing here.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
Matt Sicker <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: ant git commit: Remove redundancies

Stefan Bodewig
On 2018-08-22, Matt Sicker wrote:

> Pretty much every implementation of javac will automatically convert the
> string concatenation code into StringBuilders. Decompile the byte code and
> see for yourself.

I know that :-)

The thing I qibble about is the commit message says "remove
redundancies" and I don't see any redundancy in the original code.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: ant git commit: Remove redundancies

Gintautas Grigelionis
On Thu, 23 Aug 2018 at 07:06, Stefan Bodewig <[hidden email]> wrote:

> On 2018-08-22, Matt Sicker wrote:
>
> > Pretty much every implementation of javac will automatically convert the
> > string concatenation code into StringBuilders. Decompile the byte code
> and
> > see for yourself.
>
> I know that :-)
>
> The thing I qibble about is the commit message says "remove
> redundancies" and I don't see any redundancy in the original code.
>

Sorry, my bad. That should have been "early suboptimisation".
I believe, Java 9+ optimises string concatenation differently (or,
actually, it may use invokedynamic to delay it :-).

Gintas