.git(modules|attributes|ignore) files in source dists?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

.git(modules|attributes|ignore) files in source dists?

Stefan Bodewig
Hi all

when I set up the build for AntUnit I realized the source tarball didn't
contain the git config files that are part of the source repo and
changed the antlibs-common module to include them (they are part of
Ant's defaultexcludes for DirectoryScanner).

Later it dawned on me this may not be a good idea as we don't include
anything else that is SCM related either, so maybe not including the
files has been the correct choice all along.

Any opinions on whether we should include or exclude them?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: .git(modules|attributes|ignore) files in source dists?

Jaikiran Pai
I don't have a preference on whether or not to include the SCM related
files, but at least in the recent IvyDE release process, I setup the
build to use "git archive" command to generate these source tar/zip
packages[1]. The documentation of git archive doesn't explicitly state
anything about files like .gitignore being packaged into the archive. So
I looked into the generated source tar and those are indeed present.

I actually can't think of a reason why we should exclude these files.

[1] https://github.com/apache/ant-ivyde/blob/master/build.xml

-Jaikiran


On 19/06/18 8:12 PM, Stefan Bodewig wrote:

> Hi all
>
> when I set up the build for AntUnit I realized the source tarball didn't
> contain the git config files that are part of the source repo and
> changed the antlibs-common module to include them (they are part of
> Ant's defaultexcludes for DirectoryScanner).
>
> Later it dawned on me this may not be a good idea as we don't include
> anything else that is SCM related either, so maybe not including the
> files has been the correct choice all along.
>
> Any opinions on whether we should include or exclude them?
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: .git(modules|attributes|ignore) files in source dists?

Gintautas Grigelionis
Please see [1]

Gintas

[1] https://feeding.cloud.geek.nz/posts/excluding-files-from-git-archive/

On Wed, 20 Jun 2018 at 05:43, Jaikiran Pai <[hidden email]> wrote:

> I don't have a preference on whether or not to include the SCM related
> files, but at least in the recent IvyDE release process, I setup the
> build to use "git archive" command to generate these source tar/zip
> packages[1]. The documentation of git archive doesn't explicitly state
> anything about files like .gitignore being packaged into the archive. So
> I looked into the generated source tar and those are indeed present.
>
> I actually can't think of a reason why we should exclude these files.
>
> [1] https://github.com/apache/ant-ivyde/blob/master/build.xml
>
> -Jaikiran
>
>
> On 19/06/18 8:12 PM, Stefan Bodewig wrote:
> > Hi all
> >
> > when I set up the build for AntUnit I realized the source tarball didn't
> > contain the git config files that are part of the source repo and
> > changed the antlibs-common module to include them (they are part of
> > Ant's defaultexcludes for DirectoryScanner).
> >
> > Later it dawned on me this may not be a good idea as we don't include
> > anything else that is SCM related either, so maybe not including the
> > files has been the correct choice all along.
> >
> > Any opinions on whether we should include or exclude them?
> >
> > Stefan
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: .git(modules|attributes|ignore) files in source dists?

Nicolas Lalevée
In reply to this post by Stefan Bodewig


> Le 19 juin 2018 à 16:42, Stefan Bodewig <[hidden email]> a écrit :
>
> Hi all
>
> when I set up the build for AntUnit I realized the source tarball didn't
> contain the git config files that are part of the source repo and
> changed the antlibs-common module to include them (they are part of
> Ant's defaultexcludes for DirectoryScanner).
>
> Later it dawned on me this may not be a good idea as we don't include
> anything else that is SCM related either, so maybe not including the
> files has been the correct choice all along.
>
> Any opinions on whether we should include or exclude them?

My preference is that the packaged sources should be as close as possible to a direct checkout from the SCM. I like very much the idea that packaging is about calling git archive. It is then a no brainer, if it can build from a checkout, then it can build from a source archive.

I don’t directly answer your question though.
I would say then that we should (and not must) include them.

Nicolas


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]